Allow access modifiers to auto properties getters and setters

[ijklam]

Description

• Original suggestion
• RFC
• Previous merged work

Fixes#16854

Checklist

• Test cases added
• sig file support
• new syntax in fsi printing
  
• new syntax in quickinfo
  
• new syntax in sig file generation

moduleProgramtypeA()=member valinternalB:int =0with get, set
member valD:int =0withinternal get,private set
memberinternal_.Fwith get()=1andset(v:int)=()memberinternal_.Gwith get(x:int)=1andset(x:int)(v:int)=()// above generatesmoduleProgramtypeA=new: unit -> A
memberB:int with internal get,internal setmemberD:int with internal get,private setmemberF:int with internal get,internal setmemberG:x:int ->int with internal get,internal set

• Performance benchmarks added in case of performance changes
• Release notes entry updated:

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/9.0.100.md
LanguageFeatures.fsi	docs/release-notes/.Language/preview.md

[vzarytovskii]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[edgarfgp]

This seems to be ready, apart from conflicts. Would be good to have this in please 🙏

[psfinaki]

@Tangent-90 will you have time to get to this or maybe you have fresh thoughts? If no - which is understood since we didn't get to this in a timely manner - I can probably fix the conflicts and give it a proper review next week.

[ijklam]

@Tangent-90 will you have time to get to this or maybe you have fresh thoughts? If no - which is understood since we didn't get to this in a timely manner - I can probably fix the conflicts and give it a proper review next week.

Sorry for the lately response, I may try to fix it in this weekend.

[psfinaki]

Mhm this is probably okay but to be on the safe side I would not change warning numbers here. I know this happened because another features got introduced since this PR was created, sorry for inconvenience therefore.

[psfinaki]

@auduchinok if you're nearby, PTAL if you're okay with the parser changes (look reasonable to me).

[psfinaki]

Suggested change

	/// Represents two access
	/// Represents two access modifiers

[psfinaki]

Good stuff, thanks for adding the signature support and extra tests. Left a few small remarks.