Skip to content

Computed collections: simple count check - #16947

Merged
abonie merged 3 commits into
dotnet:mainfrom
brianrourkeboll:computed-collections-simple-count-check
Apr 4, 2024
Merged

Computed collections: simple count check#16947
abonie merged 3 commits into
dotnet:mainfrom
brianrourkeboll:computed-collections-simple-count-check

Conversation

@brianrourkeboll

@brianrourkebollbrianrourkeboll commented Mar 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Followup to #16650 and #16832.

  • Use count = 0 instead of count < 1. The count < 1 check was a vestige of an older approach for computing the count and isn't needed.

Checklist

  • Test cases added.
  • Release notes entry updated.

@brianrourkeboll
Use count = 0 instead of count < 1
b926f10
* The count < 1 check was a vestige of an older approach for computing
the count that could result in a negative count.
@brianrourkeboll
Update baselines
77cff30
@github-actions

github-actionsBot commented Mar 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@brianrourkeboll
brianrourkeboll marked this pull request as ready for review March 26, 2024 00:30
@brianrourkeboll
brianrourkeboll requested a review from a team as a code ownerMarch 26, 2024 00:30
@psfinaki

psfinaki commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Mar 26, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

psfinaki
psfinaki reviewed Mar 26, 2024
View reviewed changes
Comment threadsrc/Compiler/Optimize/LowerComputedCollections.fs
@abonie
abonie merged commit 71442c8 into dotnet:mainApr 4, 2024
@brianrourkeboll
brianrourkeboll deleted the computed-collections-simple-count-check branch April 5, 2024 14:59
This was referenced Apr 9, 2024
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieabonie approved these changes
+1 more reviewer
@psfinakipsfinakipsfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianrourkeboll@psfinaki@abonie