Skip to content

Improve error reporting for abstract members when used in classes - #17063

Merged
psfinaki merged 14 commits into
dotnet:mainfrom
edgarfgp:abstract-member-on-classes-reporting
Apr 19, 2024
Merged

Improve error reporting for abstract members when used in classes#17063
psfinaki merged 14 commits into
dotnet:mainfrom
edgarfgp:abstract-member-on-classes-reporting

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Apr 17, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Follow up: #17055

Checklist

  • Test cases added
  • Release notes entry updated:

@github-actions

github-actionsBot commented Apr 17, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/8.0.400.md

edgarfgp
edgarfgp commented Apr 19, 2024
View reviewed changes
Comment threadsrc/Compiler/Checking/MethodOverrides.fs
@edgarfgp
edgarfgp marked this pull request as ready for review April 19, 2024 10:00
@edgarfgp
edgarfgp requested a review from a team as a code ownerApril 19, 2024 10:00
T-Gro
T-Gro reviewed Apr 19, 2024
View reviewed changes
Comment threadsrc/Compiler/FSStrings.resx Outdated
psfinaki
psfinaki reviewed Apr 19, 2024
View reviewed changes
Comment threadsrc/Compiler/FSStrings.resx Outdated
psfinaki
psfinaki approved these changes Apr 19, 2024
View reviewed changes

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nitpicking. Good job :)

edgarfgpand others added 2 commits April 19, 2024 14:22
@edgarfgp@psfinaki
Update src/Compiler/FSStrings.resx
371c484
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
@edgarfgp
Another one
48650b1
@psfinaki

psfinaki commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

:shipit:

@psfinaki
psfinaki merged commit 89e6411 into dotnet:mainApr 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@psfinakipsfinakipsfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp@psfinaki@T-Gro