Skip to content

FS1118 on inlined function in private module from SDK 8.0.300 #17161 - #17168

Merged
KevinRansom merged 2 commits into
dotnet:mainfrom
KevinRansom:opt
May 20, 2024
Merged

FS1118 on inlined function in private module from SDK 8.0.300 #17161#17168
KevinRansom merged 2 commits into
dotnet:mainfrom
KevinRansom:opt

Conversation

@KevinRansom

@KevinRansomKevinRansom commented May 17, 2024

Copy link
Copy Markdown
Contributor

Fixes: #17161

  • Add test cases
  • Fix it

This is a regression it should go into 8.0.300
/cc @vzarytovskii , @baronfel

@KevinRansom
KevinRansom requested a review from a team as a code ownerMay 17, 2024 04:37
@KevinRansom
KevinRansom marked this pull request as draft May 17, 2024 04:37
@github-actions

github-actionsBot commented May 17, 2024

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansomKevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label May 17, 2024
@KevinRansom
KevinRansom marked this pull request as ready for review May 17, 2024 06:59
@KevinRansomKevinRansom changed the title InvestigateFS1118 on inlined function in private module from SDK 8.0.300 #17161May 17, 2024
@KevinRansomKevinRansom added NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes and removed NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes labels May 17, 2024
@emz00

Copy link
Copy Markdown

Thanks for the quick fix! Does this also fix the warning for class members?

@vzarytovskii

Copy link
Copy Markdown
Member

/backport to release/dev17.10

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/dev17.10: https://github.com/dotnet/fsharp/actions/runs/9130940180

@github-actions

Copy link
Copy Markdown
Contributor

@vzarytovskii backporting to release/dev17.10 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: temp
Using index info to reconstruct a base tree...
M	src/Compiler/Optimize/Optimizer.fs
M	tests/AheadOfTime/Trimming/check.ps1
Falling back to patching base and 3-way merge...
Auto-merging tests/AheadOfTime/Trimming/check.ps1
CONFLICT (content): Merge conflict in tests/AheadOfTime/Trimming/check.ps1
Auto-merging src/Compiler/Optimize/Optimizer.fs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 temp
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@dotnetdotnet deleted a comment from github-actionsBotMay 17, 2024
@KevinRansom

Copy link
Copy Markdown
ContributorAuthor

@loop-evgeny, Sorry not to get back to you, it was 1:00 am last night when I propped this PR. I believe this will take care of the class issues too, I will add test cases for it and also verify #17161.

@KevinRansom
KevinRansom marked this pull request as draft May 17, 2024 18:47
@KevinRansom
KevinRansom marked this pull request as ready for review May 17, 2024 21:52
@KevinRansom
KevinRansom enabled auto-merge (squash) May 20, 2024 17:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

FS1118 on inlined function in private module from SDK 8.0.300

4 participants

@KevinRansom@emz00@vzarytovskii@abonie