Uh oh!
There was an error while loading. Please reload this page.
Cherry pick - #17176
Merged
Merged
Conversation
Contributor
|
vzarytovskii
commented
May 18, 2024
Member
Do we need to bump package version, so nuget is uploaded as well? |
ContributorAuthor
Yes Done: |
T-Gro
approved these changes
May 20, 2024
vzarytovskii
commented
May 20, 2024
Member
We shouldn't have merged it before tactics approval for the backport |
This was referenced May 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #17161
Description
We didn't inline so good, now we do
Customer Impact
Code that compiled in previous SDKs that was correct no longer compiled when updating to 8.0.300. Users would have to make code changes to adjust to our incorrect analysis.
Regression?
Yes, ...
Risk
Low, we have manual and automated tests to cover this now.