Uh oh!
There was an error while loading. Please reload this page.
Fix MultipleDiagnosticsLoggers.Parallel deadlock - #17208
Merged
Merged
Conversation
Contributor
|
majocha
commented
May 22, 2024
ContributorAuthor
I think this is ready. |
psfinaki
commented
May 22, 2024
Contributor
@ForNeVeR maybe take a look if you have a chance :) |
ForNeVeR
approved these changes
May 22, 2024
ForNeVeR
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I cannot imagine a scenario when this breaks (so far!)
psfinaki
approved these changes
May 22, 2024
vzarytovskii
commented
May 22, 2024
Member
Famous last words, but lgtm too |
vzarytovskii
commented
May 22, 2024
Member
/run fantomas |
vzarytovskii
approved these changes
May 22, 2024
T-Gro
approved these changes
May 23, 2024
psfinaki
commented
May 23, 2024
Contributor
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced May 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes#17205
Checklist