Uh oh!
There was an error while loading. Please reload this page.
Don't cause index out of range exn in completion - #17227
Merged
Merged
Conversation
* Dotting into delegates with multiple type arguments would trigger an index out of range exception. Now it doesn't.
Contributor
❗ Release notes required
|
brianrourkeboll
marked this pull request as ready for review
May 22, 2024 14:29
This was referenced May 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes#17226.
Checklist
Tests: I spent a while trying to get a test for this to work, but it seems like it might be rather difficult, since this pathway only seems to be called sometimes. Compare:
fsharp/src/Compiler/Service/FSharpCheckerResults.fs
Lines 1316 to 1318 in ef2307d
But here's a recording of the fix working:
dot_delegate_working.mp4
Release notes entry updated.