Skip to content

Support empty-bodied computation expressions - #17352

Merged
T-Gro merged 14 commits into
dotnet:mainfrom
brianrourkeboll:empty-bodied-cexprs
Jul 1, 2024
Merged

Support empty-bodied computation expressions#17352
T-Gro merged 14 commits into
dotnet:mainfrom
brianrourkeboll:empty-bodied-cexprs

Conversation

@brianrourkeboll

@brianrourkebollbrianrourkeboll commented Jun 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Examples

builder {}
seq{}

Checklist

  • Test cases added.
  • Release notes entry updated.

Important

Shoutout to @edgarfgp@fabulous-dev for sponsoring my work on this.

@github-actions

github-actionsBot commented Jun 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/8.0.400.md
LanguageFeatures.fsidocs/release-notes/.Language/preview.md

This was referenced Jun 26, 2024
Closed
Merged
@brianrourkeboll
brianrourkeboll marked this pull request as ready for review June 26, 2024 18:16
@brianrourkeboll
brianrourkeboll requested a review from a team as a code ownerJune 26, 2024 18:16
@vzarytovskii

vzarytovskii commented Jun 26, 2024

Copy link
Copy Markdown
Member

Haven't reviewed it yet, but thinking out loud:

How would this play with resumable state machines. I assume it should be fine since it's just a transformation essentially.

And second, orthogonal comment - this feature will encourage more CE use, which my itself is not bad, but might lead to more nested CEs, which will involve more checking = being slower. We really need to do something with it. I made an attempt or two in the past, but change surface was bigger than I anticipated.

@brianrourkeboll

brianrourkeboll commented Jun 26, 2024

Copy link
Copy Markdown
ContributorAuthor

How would this play with resumable state machines. I assume it should be fine since it's just a transformation essentially.

That's a good call-out. I'll add some tests to make sure.

@psfinaki

psfinaki commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jun 27, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki

psfinaki commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

Cool stuff! Hope to give it a review soon. Can be a nice and intuitive addition to the language.

T-Gro
T-Gro reviewed Jun 27, 2024
View reviewed changes
Comment threaddocs/release-notes/.Language/preview.md
@brianrourkeboll
Adjust task test for clarity
ebae6c8
* The warning caused by dotnet#12038
distracted from the test's intent. Wrapping the code in a function
removes the warning.
@brianrourkeboll
Merge branch 'main' ofhttps://github.com/dotnet/fsharpinto empty-bo…
f1d699e
…died-cexprs
@brianrourkeboll
No longer need dedenting
d238a3e
psfinaki
psfinaki approved these changes Jun 28, 2024
View reviewed changes

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, great testing. I am not a CE guru (yet) so letting @vzarytovskii to make a final review here.

edgarfgp
edgarfgp approved these changes Jun 28, 2024
View reviewed changes

@edgarfgpedgarfgp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brianrourkeboll. Awesome work

@T-Gro
T-Gro merged commit 5c6d8e7 into dotnet:mainJul 1, 2024
@brianrourkeboll
brianrourkeboll deleted the empty-bodied-cexprs branch July 1, 2024 13:54
@edgarfgpedgarfgp mentioned this pull request Jul 10, 2024
Merged
2 tasks
This was referenced Jul 25, 2024
Closed
Closed
@dotnet-botdotnet-bot mentioned this pull request Aug 2, 2024
Closed
This was referenced Sep 8, 2025
Closed
Closed
This was referenced Oct 10, 2025
Closed
Closed
@dependabotdependabotBot mentioned this pull request Oct 27, 2025
Closed
@brianrourkebollbrianrourkeboll mentioned this pull request May 31, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+2 more reviewers
@psfinakipsfinakipsfinaki approved these changes
@edgarfgpedgarfgpedgarfgp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brianrourkeboll@vzarytovskii@psfinaki@edgarfgp@T-Gro