Skip to content

Parser: recover on missing union case fields - #17452

Merged
psfinaki merged 5 commits into
dotnet:mainfrom
auduchinok:parser-unionCaseRepr
Aug 1, 2024
Merged

Parser: recover on missing union case fields#17452
psfinaki merged 5 commits into
dotnet:mainfrom
auduchinok:parser-unionCaseRepr

Conversation

@auduchinok

@auduchinokauduchinok commented Jul 26, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Adds recovery for various unfinished union case declarations:

typeU=| A ofint*
typeU=| A ofint*int*
typeU=| A ofint**int
typeU=| A of*int*int

Also fixes range calculations. Otherwise, recovered nodes would use wrong range that spans past the node end.

@auduchinok
auduchinok requested a review from a team as a code ownerJuly 26, 2024 17:12
@github-actions

github-actionsBot commented Jul 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@vzarytovskii
vzarytovskii enabled auto-merge (squash) July 27, 2024 17:34
@auduchinokauduchinok mentioned this pull request Jul 29, 2024
Merged
psfinaki
psfinaki reviewed Jul 29, 2024
View reviewed changes
Comment threadtests/service/data/SyntaxTree/Type/Union 03.fs Outdated
auto-merge was automatically disabled July 30, 2024 13:23

Head branch was pushed to by a user without write access

@auduchinok
auduchinokforce-pushed the parser-unionCaseRepr branch from 948cfc4 to fc06f28CompareJuly 30, 2024 13:23
psfinaki
psfinaki reviewed Jul 30, 2024
View reviewed changes
Comment threadsrc/Compiler/FSComp.txt Outdated
@auduchinok

auduchinok commented Jul 30, 2024

Copy link
Copy Markdown
MemberAuthor

This is ready.

@auduchinok
auduchinokforce-pushed the parser-unionCaseRepr branch 2 times, most recently from 1fe5207 to b66c1b3CompareJuly 31, 2024 12:00
@auduchinok
auduchinokforce-pushed the parser-unionCaseRepr branch from b66c1b3 to 4ea778eCompareAugust 1, 2024 11:00
@psfinaki
psfinaki merged commit d2d38e3 into dotnet:mainAug 1, 2024
@auduchinok
auduchinok deleted the parser-unionCaseRepr branch August 1, 2024 13:14
This was referenced Aug 13, 2024
Closed
Closed
@dotnet-botdotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskiivzarytovskiivzarytovskii approved these changes
+2 more reviewers
@psfinakipsfinakipsfinaki approved these changes
@edgarfgpedgarfgpedgarfgp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@auduchinok@vzarytovskii@psfinaki@edgarfgp