Replace internal option conversion funcs with FSharp.Core ones

[brianrourkeboll]

Description

Followup to #17436.

• Remove the multiple existing internal copies of these functions in this repo and replace their usage with the FSharp.Core ones added in Module functions for 'T option ↔ 'T voption #17436.

Checklist

• These are all internal changes with no behavioral difference, so I don't think this needs release notes.

[github-actions]

❗ Release notes required

@brianrourkeboll,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/9.0.100.md	No release notes found or release notes format is not correct
vsintegration/src	docs/release-notes/.VisualStudio/17.12.md	No release notes found or release notes format is not correct

[brianrourkeboll]

@psfinaki It looks like that build step does indeed use a shipped version of FSharp.Core:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=759051&view=logs&j=e67a5d0a-7dd1-5a81-34c7-1aa43c26e99f&t=45adc47a-4d3f-5d1a-3672-ea4de47e2fc1&l=1108

/home/vsts/work/1/s/src/Compiler/TypedTree/TypedTree.fs(2120,26): error FS0039: The value, constructor, namespace or type 'ofOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]/home/vsts/work/1/s/src/Compiler/TypedTree/TypedTree.fs(4232,94): error FS0039: The value, constructor, namespace or type 'ofOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]/home/vsts/work/1/s/src/Compiler/TypedTree/TypedTree.fs(4295,91): error FS0039: The value, constructor, namespace or type 'ofOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]/home/vsts/work/1/s/src/Compiler/TypedTree/TypedTreeOps.fs(3480,117): error FS0039: The value, constructor, namespace or type 'ofOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]/home/vsts/work/1/s/src/Compiler/Service/IncrementalBuild.fs(404,77): error FS0039: The value, constructor, namespace or type 'toOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]/home/vsts/work/1/s/src/Compiler/Service/IncrementalBuild.fs(409,24): error FS0039: The value, constructor, namespace or type 'toOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]Build FAILED.

[vzarytovskii]

@psfinaki It looks like that build step does indeed use a shipped version of FSharp.Core:

dev.azure.com/dnceng-public/public/_build/results?buildId=759051&view=logs&j=e67a5d0a-7dd1-5a81-34c7-1aa43c26e99f&t=45adc47a-4d3f-5d1a-3672-ea4de47e2fc1&l=1108

/home/vsts/work/1/s/src/Compiler/TypedTree/TypedTree.fs(2120,26): error FS0039: The value, constructor, namespace or type 'ofOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
/home/vsts/work/1/s/src/Compiler/TypedTree/TypedTree.fs(4232,94): error FS0039: The value, constructor, namespace or type 'ofOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
/home/vsts/work/1/s/src/Compiler/TypedTree/TypedTree.fs(4295,91): error FS0039: The value, constructor, namespace or type 'ofOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
/home/vsts/work/1/s/src/Compiler/TypedTree/TypedTreeOps.fs(3480,117): error FS0039: The value, constructor, namespace or type 'ofOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
/home/vsts/work/1/s/src/Compiler/Service/IncrementalBuild.fs(404,77): error FS0039: The value, constructor, namespace or type 'toOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
/home/vsts/work/1/s/src/Compiler/Service/IncrementalBuild.fs(409,24): error FS0039: The value, constructor, namespace or type 'toOption' is not defined. [/home/vsts/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
Build FAILED.

It does. It's by design - @auduchinok asked us some time ago that we use package by default. It might be wrapped in #if BUILDING_WITH_LKG, I think. Or wait until F# core with this functionality ships.

[brianrourkeboll]

It might be wrapped in #if BUILDING_WITH_LKG, I think.

Hmm, adding ifdefs (if that's what you mean) would just mean that there would be more to clean up when the new version of FSharp.Core shipped. So if there's a good reason for this build step to do what it's doing, then I guess it's probably best just to wait.

[psfinaki]

@brianrourkeboll yeah I somehow missed the above as well - sorry for the confusion!

[brianrourkeboll]

All right, I opened #17460 as a reminder to do this later.

[vzarytovskii]

So if there's a good reason for this build step to do what it's doing, then I guess it's probably best just to wait.

It builds FCS with shipped compiler, it is used by the most of contributors, and folks from JB.