Skip to content

Fix object-expr untested cases - #17476

Merged
psfinaki merged 10 commits into
dotnet:mainfrom
edgarfgp:fix-objexpr-untested-case
Aug 7, 2024
Merged

Fix object-expr untested cases#17476
psfinaki merged 10 commits into
dotnet:mainfrom
edgarfgp:fix-objexpr-untested-case

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

Description

Continuation of #17388

Found some cases that weren't covered/tested before

Checklist

  • Test cases added

@github-actions

github-actionsBot commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@edgarfgpedgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 1, 2024
@edgarfgpedgarfgp changed the title Fix object-expr untested caseFix object-expr untested casesAug 1, 2024
@edgarfgp
edgarfgp marked this pull request as ready for review August 2, 2024 13:02
@edgarfgp
edgarfgp requested a review from a team as a code ownerAugust 2, 2024 13:02
@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

This is ready.

@edgarfgpedgarfgp closed this Aug 5, 2024
@edgarfgpedgarfgp reopened this Aug 5, 2024
@edgarfgpedgarfgp closed this Aug 5, 2024
@edgarfgpedgarfgp reopened this Aug 5, 2024
@psfinaki

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

KevinRansom
KevinRansom previously requested changes Aug 6, 2024

@KevinRansomKevinRansom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test cases seem to verify that the compiler compiles the source code without producing errors, could we also verify that the built type has the interface. Adding a main with a cast and executing is probably sufficient.

I'm confident it does, but a test that confirms it might be useful.

@edgarfgpedgarfgp closed this Aug 7, 2024
@edgarfgpedgarfgp reopened this Aug 7, 2024
@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

These test cases seem to verify that the compiler compiles the source code without producing errors, could we also verify that the built type has the interface. Adding a main with a cast and executing is probably sufficient.

I'm confident it does, but a test that confirms it might be useful.

Done 👍🏻

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@edgarfgp@psfinaki@vzarytovskii@KevinRansom