Skip to content

Revert ILTypeDef custom attributes changes - #17503

Merged
T-Gro merged 5 commits into
dotnet:mainfrom
auduchinok:ilTypeDef-customAttrsStored
Aug 15, 2024
Merged

Revert ILTypeDef custom attributes changes#17503
T-Gro merged 5 commits into
dotnet:mainfrom
auduchinok:ilTypeDef-customAttrsStored

Conversation

@auduchinok

Copy link
Copy Markdown
Member

The nullness PR introduced some changes that break our usages of ILTypeDef type. This PR reverts these changes.

@auduchinok
auduchinok requested a review from a team as a code ownerAugust 7, 2024 13:27
@github-actions

github-actionsBot commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

Comment threadsrc/Compiler/AbstractIL/il.fs Outdated
Co-authored-by: Alex Berezhnykh <berejnih.alex2011@yandex.ru>
@vzarytovskii

Copy link
Copy Markdown
Member

Wait, does it revert changes introduced in nullness PR, or in some other PR?

@auduchinok

Copy link
Copy Markdown
MemberAuthor

Wait, does it revert changes introduced in nullness PR, or in some other PR?

It reverts the public API changes introduced in the nullness PR. The underlying representation of ILTypeDef has not been changed there.

@vzarytovskii
vzarytovskii requested a review from T-GroAugust 7, 2024 15:08
@T-GroT-Gro self-assigned this Aug 14, 2024
@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 15, 2024
@T-Gro
T-Gro enabled auto-merge (squash) August 15, 2024 08:26
@T-Gro

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants

@auduchinok@vzarytovskii@T-Gro@DedSec256@edgarfgp