Skip to content

Detect open type use correctly for enums - #17628

Merged
vzarytovskii merged 2 commits into
dotnet:mainfrom
brianrourkeboll:open-type-enums
Aug 30, 2024
Merged

Detect open type use correctly for enums#17628
vzarytovskii merged 2 commits into
dotnet:mainfrom
brianrourkeboll:open-type-enums

Conversation

@brianrourkeboll

@brianrourkebollbrianrourkeboll commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes#17619.

  • Consider open type used when the type is an enum and any of the enum cases is used unqualified.

Checklist

  • Test cases added.
  • Release notes entry updated.

* Consider `open type` used when the type is an enum and any of
the enum cases is used unqualified.
@github-actions

github-actionsBot commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@brianrourkeboll
brianrourkeboll marked this pull request as ready for review August 28, 2024 19:05
@brianrourkeboll
brianrourkeboll requested a review from a team as a code ownerAugust 28, 2024 19:05
@brianrourkeboll
brianrourkeboll marked this pull request as draft August 28, 2024 19:13
@brianrourkeboll
brianrourkeboll marked this pull request as ready for review August 28, 2024 19:22

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix, that was annoying indeed.

@vzarytovskiivzarytovskii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

open type T when T is an enum is treated as unused even when it's used

4 participants

@brianrourkeboll@vzarytovskii@psfinaki@edgarfgp