Uh oh!
There was an error while loading. Please reload this page.
Update to .NET 9 rc1 - #17698
Conversation
✅ No release notes required |
FYI @edgarfgp@auduchinok@DedSec256@Martin521@brianrourkeboll Plain builds are unfortunately currently broken if building without Please use build scripts instead. We want to upgrade to Update: I have fixed most of issues, but there's currently no way around of using shipped FSharp.Build (and inherently FSharp.Core project). This is a current workaround until we ship .NET 9 rc2 or until I will figure out the way around it. Update 2:#17700should fix it for newer compiler + older fscore when we update to rc2. |
vzarytovskii
commented
Sep 11, 2024
I have fixed most of issues, but there's currently no way around of using shipped FSharp.Build (and inherently FSharp.Core project). |
Martin521
commented
Sep 11, 2024
Locally, everything still works fine for me. |
vzarytovskii
commented
Sep 11, 2024
It is not yet merged. This PR was breaking it by default, i "fixed" it, but it will use fsharp.core project by default as opposed to library. |
vzarytovskii
commented
Sep 11, 2024
Either way, I think rc1 update will have to wait, we're hitting |
| <!-- TODO(vlza): This probably should be `true` once fslib with nullness ships, since shipped library is preferred by default when building this solution. --> | ||
| <FSHARPCORE_USE_PACKAGE Condition="'$(FSHARPCORE_USE_PACKAGE)' == ''">false</FSHARPCORE_USE_PACKAGE> | ||
There was a problem hiding this comment.
That'd be a "workaround" to unblock plain builds, but it will by default use the project.
| <PropertyGroup Condition="'$(BUILDING_USING_DOTNET)' == 'true'"> | ||
| <CheckNulls>false</CheckNulls> | ||
| </PropertyGroup> | ||
There was a problem hiding this comment.
Turning it off currently for the plain builds, so we don't get mismatches with defines we have.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
No description provided.