Skip to content

Fix #17719 - #17722

Merged
vzarytovskii merged 4 commits into
dotnet:mainfrom
vzarytovskii:fix-17719
Sep 13, 2024
Merged

Fix #17719#17722
vzarytovskii merged 4 commits into
dotnet:mainfrom
vzarytovskii:fix-17719

Conversation

@vzarytovskii

@vzarytovskiivzarytovskii commented Sep 13, 2024

Copy link
Copy Markdown
Member

Fixes#17719

@vzarytovskii
vzarytovskii requested a review from a team as a code ownerSeptember 13, 2024 11:23
@github-actions

github-actionsBot commented Sep 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskiivzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Sep 13, 2024
vzarytovskii
vzarytovskii commented Sep 13, 2024
View reviewed changes
Comment threadsrc/Compiler/Checking/Expressions/CheckExpressions.fs
@vzarytovskii

vzarytovskii commented Sep 13, 2024

Copy link
Copy Markdown
MemberAuthor

If CI passes, I intend to force-merge it for it to go into main -> 17.12 merge and then into SDK, so we can have it in release.

T-Gro
T-Gro reviewed Sep 13, 2024
View reviewed changes
Comment threadtests/FSharp.Compiler.ComponentTests/EmittedIL/StringFormatAndInterpolation.fs
@vzarytovskii
vzarytovskii merged commit c910057 into dotnet:mainSep 13, 2024
@vzarytovskii
vzarytovskii deleted the fix-17719 branch September 13, 2024 14:05
This was referenced Sep 17, 2024
Closed
Closed
@dotnet-botdotnet-bot mentioned this pull request Oct 1, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieabonie approved these changes
@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@KevinRansomKevinRansomKevinRansom approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InvalidProgramException on string interpolation

4 participants

@vzarytovskii@KevinRansom@abonie@T-Gro