Uh oh!
There was an error while loading. Please reload this page.
Move attribute enforcement from v9 to preview - #17739
Conversation
|
vzarytovskii
commented
Sep 15, 2024
@T-Gro did you confirm that this feature is causing the regression? |
T-Gro
commented
Sep 15, 2024
See the modified tests, the "No constructors are available for the type" issue is the same as the original. (and should not be there, because the type does have a constructor) |
There was a problem hiding this comment.
I do not remember modifying this file as part of my PRs 🧐.
There was a problem hiding this comment.
The negative typecheck tests do not run with langver=preview, this was only modified when the feature was enabled by default: https://github.com/dotnet/fsharp/pull/17558/files#diff-036387972a5f139a8b0f05f5b702666c5d77d961a15f0b9ac170264d79dd1c11
edgarfgp
commented
Sep 16, 2024
@vzarytovskii should be this reverted now that #17731 has been fixed ? |
vzarytovskii
commented
Sep 16, 2024
Yes, it won't make it to release though |
This reverts commit b9df594.
edgarfgp
commented
Sep 16, 2024
But it will be in one of the point releases right ? |
vzarytovskii
commented
Sep 16, 2024
Yeah |
No description provided.