Uh oh!
There was an error while loading. Please reload this page.
Fix #17713 (sourcebuild phase 2 build error) - #17748
Conversation
✅ No release notes required |
ellahathaway
commented
Sep 16, 2024
Please also backport this to 9.0 (I believe fsharp's |
I'm afraid this isn't the right fix: Firstly, Secondly, Using ConsistentNowarnLineDirectiveInteraction when compiled with /langversion:8.0 Note!!!!: The purpose of the langversion switch is to select the language version that is compatible with earlier versions of the compiler. The intent is to support teams of developers with mixed toolsets, I.e one dev with a net8.0 toolset and another with net9.0 --- the net 9.0 developer selects langversion 8.0 so that he doesn't use new features or introduce new errors that will impact the developer using the net 8.0 toolset. Thirdly, I do agree that the current implementation in the shipped compilers is not great and needs to be redesigned and re-implemented. However, the change proposed in the ConsistentNowarnLineDirectiveInteraction may not be the correct one. |
Martin521
commented
Sep 16, 2024
On the first item: The second and third item were described in detail in the original PR. |



Description
This is a fix for #17713, by a change on top of #17649 to make the interaction between #line and #nowarn directives consistent.
This PR is an alternative to #17724 (reverting #17649).
It updates
fsyaccpars.fsto the latest version of the upstream repository.