Uh oh!
There was an error while loading. Please reload this page.
Improve StartWithContinuations test in AsyncType tests - #17767
Merged
Conversation
Contributor
✅ No release notes required |
ContributorAuthor
New version goes like this: moduleAsyncType =typeExpectedContinuation= Success | Exception | Cancellation
[<Fact>]letstartWithContinuations()=letcont actual expected _ =if expected <> actual then
failwith $"expected {expected} continuation, but ran {actual}"letonSuccess= cont Success
letonExeption= cont Exception
letonCancellation= cont Cancellation
letexpect expected computation =
Async.StartWithContinuations(computation, onSuccess expected, onExeption expected, onCancellation expected)async{
Async.CancelDefaultToken()return()}|> expect Cancellation
async{ failwith "computation failed"}|> expect Exception
async{return()}|> expect Success |
Uh oh!
There was an error while loading. Please reload this page.
psfinaki
approved these changes
Sep 23, 2024
psfinaki
left a comment
Contributor
There was a problem hiding this comment.
Okay I think I've verified the equivalence, thanks for the refactoring, it definitely looks clearer now.
…ol/AsyncType.fs Co-authored-by: Petr <psfinaki@users.noreply.github.com>
T-Gro
approved these changes
Sep 30, 2024
This was referenced Oct 31, 2024
This was referenced Sep 8, 2025
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a local cancellation token instead ofAsync.CancelDefaultToken()to cancel just one computation.When running tests in parallel I've seen
OperationCancelledExceptionraised in unrelated tests of the same assembly.It seems despite the fact this test collection has
DisableParallelization = true,xUnit sometimes can't perfectly isolate the test cases.ETA: It was me misconfiguring xUnit exclusions.
Still, I think this looks a bit cleaner.