Uh oh!
There was an error while loading. Please reload this page.
Remove unused useSyntaxTreeCache option - #17768
Conversation
❗ Release notes required
|
psfinaki
commented
Sep 20, 2024
I think surface area will need an update as well. |
Uh oh!
There was an error while loading. Please reload this page.
majocha
commented
Sep 26, 2024
The consensus is to remove it. It was also still marked experimental. |
psfinaki
commented
Sep 26, 2024
I just noticed it's also present in VS settings. I think we should remove it there as well then :) |
psfinaki
commented
Sep 26, 2024
(use_syntax_tree_cache) |
majocha
commented
Sep 26, 2024
I think this is already done in this PR. |
psfinaki
commented
Sep 26, 2024
Right, sorry, I somehow mis-scrolled it 🤦 Thanks! |
psfinaki
left a comment
There was a problem hiding this comment.
Thanks, I think this PR can serve as a good manual on how to add / remove an option to the compiler and propagate / unpropagate it everywhere :)
psfinaki
commented
Sep 27, 2024
Oh I know what I meant. This is still left in the resources via keywords, here. So can be removed there as well. |
majocha
commented
Sep 27, 2024
Right, couldn't find anything with search in files, makes sense now :) |
Clean up.
This functionality is no longer configurable, and that cache no longer exists as a separate value in the builder.
Instead
SyntaxTreecaching occurs naturally by preservingGraphNodecomputed values, IIRC.