Skip to content

Remove unused useSyntaxTreeCache option - #17768

Merged
T-Gro merged 8 commits into
dotnet:mainfrom
majocha:remove-option
Sep 30, 2024
Merged

Remove unused useSyntaxTreeCache option#17768
T-Gro merged 8 commits into
dotnet:mainfrom
majocha:remove-option

Conversation

@majocha

Copy link
Copy Markdown
Contributor

Clean up.
This functionality is no longer configurable, and that cache no longer exists as a separate value in the builder.
Instead SyntaxTree caching occurs naturally by preserving GraphNode computed values, IIRC.

@majocha
majocha requested a review from a team as a code ownerSeptember 20, 2024 07:48
@github-actions

github-actionsBot commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.200.md
vsintegration/srcdocs/release-notes/.VisualStudio/17.12.md

@psfinaki

Copy link
Copy Markdown
Contributor

I think surface area will need an update as well.

Comment threadsrc/Compiler/Service/service.fs
@majocha

Copy link
Copy Markdown
ContributorAuthor

The consensus is to remove it. It was also still marked experimental.

@psfinaki

Copy link
Copy Markdown
Contributor

I just noticed it's also present in VS settings. I think we should remove it there as well then :)

@psfinaki

Copy link
Copy Markdown
Contributor

(use_syntax_tree_cache)

@majocha

Copy link
Copy Markdown
ContributorAuthor

I think this is already done in this PR.

@psfinaki

Copy link
Copy Markdown
Contributor

Right, sorry, I somehow mis-scrolled it 🤦 Thanks!

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this PR can serve as a good manual on how to add / remove an option to the compiler and propagate / unpropagate it everywhere :)

@psfinaki

Copy link
Copy Markdown
Contributor

Oh I know what I meant. This is still left in the resources via keywords, here. So can be removed there as well.

@majocha

Copy link
Copy Markdown
ContributorAuthor

Right, couldn't find anything with search in files, makes sense now :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants

@majocha@psfinaki@baronfel@vzarytovskii@auduchinok@T-Gro