Uh oh!
There was an error while loading. Please reload this page.
Removing Nunit from utils - #17770
Conversation
✅ No release notes required |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Related: #13654
TL;DR: We are nearly done!
Please see my comments everywhere, this is close to the equivalent code, with minor simplifications and fixes.
Note this increases the number of tests executed in the CI. The execution time is not affected.
Main:

This branch:

This is due to:
FSharpSuite. Those are old-newAsyncTestsand they are skipped anyway for now. See comment.ComponentTests.TypeChecks. Of those:CompilationFromCmdlineArgsTestsand 1TypedTreeGraphTests- those were explicit + failing, now skippedDependencyResolutionTests- this is legit and passing, wasn't being executed as[<Theory>]was forgotten thereFileContentMappingTests, 1GraphProcessingTests, 4QueryTrieTests, 18TrieMappingTests- those are legit and passing, weren't being executed because weren't rewritten to Xunit (so trying executing non-existing Nunit adapter)