Skip to content

Better error reporting for CEmatch! - #17789

Merged
vzarytovskii merged 5 commits into
dotnet:mainfrom
edgarfgp:better-error-reporting-ce-match-bang
Sep 26, 2024
Merged

Better error reporting for CEmatch!#17789
vzarytovskii merged 5 commits into
dotnet:mainfrom
edgarfgp:better-error-reporting-ce-match-bang

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

Description

Better error reporting for CEmatch!

Continuation of #17779

Before

Screenshot 2024-09-25 at 13 59 23

After

letrun r2 r3 =match! r2 with^^^^^^| Ok x -> x
| Error e -> e

Checklist

  • Test cases added
  • Release notes entry updated

@edgarfgp
edgarfgp requested a review from a team as a code ownerSeptember 25, 2024 15:07
@github-actions

github-actionsBot commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

This is ready

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I basically reviewed this in the previous PR :) Thanks Edgar, thanks for covering match! with some tests.

@edgarfgpedgarfgp reopened this Sep 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp@vzarytovskii@psfinaki