Better error reporting for return, yield, return! and yield!

[edgarfgp]

Description

Better error reporting for return, yield, return! and yield!

Continuation of #17779

Before

After

letf1=return[3;4]^^^^^^letf2=return![3;4]^^^^^^^

Before

After

letf3=[iftruethen"a""b"yield![3;4]^^^^^^^^]

Before

After

letf4=async{iftruethenyield"a"^^^^^elseyield"b"}

Before

After

letmaybeTask=task{returnfalse}letindexHandler():Task<string>=task{return! maybeTask
^^^^^^^^^}

Checklist

• Test cases added
• Release notes entry updated:

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/9.0.200.md
vsintegration/src	docs/release-notes/.VisualStudio/17.12.md

[edgarfgp]

The failing tests in this PR are the FSharp.Editor.Tests.CodeFixes.RemoveReturnOrYieldTests which are VS specific. Unfortunately I no longer own a Windows machine. @psfinaki would you able to help me with these failing test ?

[psfinaki]

Hmm looking at the tests, this change indeed breaks the code fix. Although the code fix itself is quite simple, shouldn't be a big deal, hope I'll get to it later today.

[psfinaki]

There you go, there is some change in range/span arithmetic there, added a few extra tests just to be sure :)

[edgarfgp]

There you go, there is some change in range/span arithmetic there, added a few extra tests just to be sure :)

Thank you Sir. Enjoy the holidays :)

[edgarfgp]

This is ready