Uh oh!
There was an error while loading. Please reload this page.
Ensure frameworkTcImportsCache mutations are threadsafe - #17795
Merged
psfinaki merged 5 commits intoSep 26, 2024
Conversation
Contributor
❗ Release notes required
|
T-Gro
approved these changes
Sep 26, 2024
majocha
marked this pull request as ready for review
September 26, 2024 16:50
8 tasks
psfinaki
approved these changes
Sep 26, 2024
psfinaki
left a comment
Contributor
There was a problem hiding this comment.
Thanks, that's definitely for good.
psfinaki
enabled auto-merge (squash)
September 26, 2024 18:42
This was referenced Oct 31, 2024
This was referenced Sep 8, 2025
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running tests in parallel there happened some intermittent internal errors, all of them variations of NRE.
I tracked it down to data corruption because of concurrent mutation of
frameworkTcImportsCache.