Skip to content

Better error reporting for use - #17811

Merged
vzarytovskii merged 16 commits into
dotnet:mainfrom
edgarfgp:better-error-reporing-for-ce-use
Oct 8, 2024
Merged

Better error reporting for use#17811
vzarytovskii merged 16 commits into
dotnet:mainfrom
edgarfgp:better-error-reporing-for-ce-use

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

Description

Better error reporting for use

Continuation of #17779

Before

Screenshot 2024-09-30 at 20 09 48

Screenshot 2024-09-30 at 20 10 12

After

letx11= query {for c in[1..10]douse x ={new System.IDisposable with__.Dispose()=()}^^^yield1}letrun r2 r3 =
result {use b = r2
^^^return Ok 0}

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp
edgarfgp marked this pull request as ready for review September 30, 2024 19:27
@edgarfgp
edgarfgp requested a review from a team as a code ownerSeptember 30, 2024 19:27
@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

This is ready

@edgarfgp
edgarfgp requested review from T-Gro and abonieOctober 1, 2024 18:47
@vzarytovskii
vzarytovskii enabled auto-merge (squash) October 3, 2024 20:36
@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

Can I have a second review please ?

@edgarfgpedgarfgp closed this Oct 4, 2024
auto-merge was automatically disabled October 4, 2024 16:55

Pull request was closed

@edgarfgpedgarfgp reopened this Oct 4, 2024
# Conflicts:
#	tests/FSharp.Compiler.ComponentTests/Language/ComputationExpressionTests.fs
@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

Fixed merge conflicts and it is green again.

@vzarytovskii
vzarytovskii merged commit 69cc8a4 into dotnet:mainOct 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

@edgarfgp@vzarytovskii