Uh oh!
There was an error while loading. Please reload this page.
Asorted tests improvements - #17840
Conversation
✅ No release notes required |
majocha
commented
Oct 7, 2024
This comes down to the timeout here being too tight for the CI occasionally: fsharp/tests/FSharp.Test.Utilities/CompilerAssert.fs Lines 665 to 666 in 8eec34b Maybe it would make sense to get rid of such hardcoded timeouts altogether. In the IDE it's obvious when a test hangs and in the CI we can just use |
majocha
commented
Oct 8, 2024
I used |
Uh oh!
There was an error while loading. Please reload this page.
majocha
commented
Oct 15, 2024
They're still not perfect. Using just sync primitives often obfuscates the code. Now I think some sort of simulated time, Rx style, would make the code more clear. But at the cost of making the tests depend on yet another thing. |
psfinaki
commented
Oct 15, 2024
Well - we're leaving the playground in the better shape we've found it 👀 |
Martin521
commented
Oct 15, 2024
Great improvement indeed |
Cherrypicked from #17662.
Async.Startetc. and not observed / awaited. They will escape the confinement of currently running test case and if they throw, they bring down the whole test hostexit 0in the codeMailbox.TryScanbecause we had none outside of the core\controlMailbox script.