Skip to content

Better inherit error reporting - #17879

Merged
psfinaki merged 6 commits into
dotnet:mainfrom
edgarfgp:inherit-better-ranges
Oct 15, 2024
Merged

Better inherit error reporting#17879
psfinaki merged 6 commits into
dotnet:mainfrom
edgarfgp:inherit-better-ranges

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

Description

Bette error reporting for inherit.

Before

Screenshot 2024-10-15 at 09 04 39

Screenshot 2024-10-15 at 09 05 56

Screenshot 2024-10-15 at 09 07 55

After

typeIA=interfaceendtypeClass()=inherit IA
^^^^^^^^^[<Sealed>]typeBaseClass()=classendtypeClass2()=inherit BaseClass()^^^^^^^^^// Another interface typeTK_I_005=abstractM :unit->unit[<Struct>]typeTK_I_006b=inherit TK_I_005
^^^^^^^^

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp
edgarfgp marked this pull request as ready for review October 14, 2024 13:39
@edgarfgp
edgarfgp requested a review from a team as a code ownerOctober 14, 2024 13:39
@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

This is ready

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff Edgar, thanks!

I thought - maybe you can add a small paragraph to the docs about improving our diagnostics the way you do - and reference some of your PRs. That could be useful :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp@psfinaki@T-Gro