Skip to content

Better error range for struct and restricted super types inherit - #17886

Merged
psfinaki merged 7 commits into
dotnet:mainfrom
edgarfgp:better-error-range-for-inherit
Oct 16, 2024
Merged

Better error range for struct and restricted super types inherit#17886
psfinaki merged 7 commits into
dotnet:mainfrom
edgarfgp:better-error-range-for-inherit

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Description

Better error range for struct and restricted super types inherit.

Before

Screenshot 2024-10-15 at 22 47 19

After

typeC1=classinherit System.ValueType overridex.ToString()=""end^^^^^^^^^^^^^^^^typeTK_I_005=abstractM :unit->unit[<Struct>]typeTK_I_006b=inherit TK_I_005
^^^^^^^^

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgpedgarfgp changed the title Better error range for struct inheritBetter error range for struct and restricted super types inheritOct 15, 2024
@edgarfgp
edgarfgp marked this pull request as ready for review October 15, 2024 21:19
@edgarfgp
edgarfgp requested a review from a team as a code ownerOctober 15, 2024 21:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@edgarfgp@vzarytovskii@T-Gro@psfinaki