Skip to content

Fix Internal error when analysing incomplete inherit member - #17905

Merged
psfinaki merged 14 commits into
dotnet:mainfrom
edgarfgp:fix-17902
Oct 24, 2024
Merged

Fix Internal error when analysing incomplete inherit member#17905
psfinaki merged 14 commits into
dotnet:mainfrom
edgarfgp:fix-17902

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes#17902

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.200.md

Comment threadsrc/Compiler/SyntaxTree/SyntaxTree.fs Outdated

@brianrourkebollbrianrourkeboll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: I generally think keeping pattern matching flat where possible (instead of adding nested match expressions) makes the top-level match easier to understand, but feel free to ignore if you disagree.

Comment threadsrc/Compiler/Service/ServiceParseTreeWalk.fs Outdated
Comment threadsrc/Compiler/Driver/GraphChecking/FileContentMapping.fs Outdated
Comment threadsrc/Compiler/Service/ServiceParsedInputOps.fs Outdated
Comment threadsrc/Compiler/Service/ServiceParsedInputOps.fs Outdated
edgarfgpand others added 6 commits October 21, 2024 18:55
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

@psfinaki Sorry to bother you again. Could you help me update the last salsa test https://dev.azure.com/dnceng-public/public/_build/results?buildId=850191&view=ms.vss-test-web.build-test-results-tab&runId=22075436&resultId=108303&paneView=debug. Trying to do it using the CI is really painful :(

@psfinaki

Copy link
Copy Markdown
Contributor

@edgarfgp there you go (hopefully), pushed to your branch. You cannot want the same thing to be both expected and unexpected in the list of completions :)

Judging by the name of the test, I think this PR decreases the amount of contexts without completions - for better or worse.

@edgarfgp
edgarfgp marked this pull request as ready for review October 23, 2024 16:45
@edgarfgp
edgarfgp requested a review from a team as a code ownerOctober 23, 2024 16:45
@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

This is ready

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Internal error when analyzing incomplete inherit member

5 participants

@edgarfgp@psfinaki@auduchinok@brianrourkeboll@T-Gro