Uh oh!
There was an error while loading. Please reload this page.
Fix Internal error when analysing incomplete inherit member - #17905
Conversation
❗ Release notes required
|
Uh oh!
There was an error while loading. Please reload this page.
brianrourkeboll
left a comment
There was a problem hiding this comment.
Style nit: I generally think keeping pattern matching flat where possible (instead of adding nested match expressions) makes the top-level match easier to understand, but feel free to ignore if you disagree.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com>
edgarfgp
commented
Oct 22, 2024
@psfinaki Sorry to bother you again. Could you help me update the last salsa test https://dev.azure.com/dnceng-public/public/_build/results?buildId=850191&view=ms.vss-test-web.build-test-results-tab&runId=22075436&resultId=108303&paneView=debug. Trying to do it using the CI is really painful :( |
psfinaki
commented
Oct 23, 2024
@edgarfgp there you go (hopefully), pushed to your branch. You cannot want the same thing to be both expected and unexpected in the list of completions :) Judging by the name of the test, I think this PR decreases the amount of contexts without completions - for better or worse. |
edgarfgp
commented
Oct 23, 2024
This is ready |
psfinaki
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Description
Fixes#17902
Checklist