Skip to content

Re-enable TransparentCompiler tests - #17966

Merged
0101 merged 13 commits into
dotnet:mainfrom
majocha:reenable-tests-3
Nov 9, 2024
Merged

Re-enable TransparentCompiler tests#17966
0101 merged 13 commits into
dotnet:mainfrom
majocha:reenable-tests-3

Conversation

@majocha

@majochamajocha commented Nov 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Another result from explorations of parallel testing.

Added a Updating property to AsyncMemoize that is observed during tests instead of relying on Async.Sleeps and so on.
Adjusted test cases appropriately to use it.

Closes#16766.

Checklist

  • Make sure no test case was left behind.
  • Make sure semantics of the original test cases are preserved.

@majocha
majocha requested a review from a team as a code ownerNovember 6, 2024 20:03
@github-actions

github-actionsBot commented Nov 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@majochamajocha mentioned this pull request Nov 6, 2024
Closed
@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Nov 7, 2024
majocha
majocha commented Nov 7, 2024
View reviewed changes
Comment threadtests/FSharp.Compiler.ComponentTests/FSharpChecker/TransparentCompiler.fs
majocha
majocha commented Nov 7, 2024
View reviewed changes
Comment threadtests/FSharp.Compiler.ComponentTests/FSharpChecker/TransparentCompiler.fs
majocha
majocha commented Nov 7, 2024
View reviewed changes
Comment threadtests/FSharp.Compiler.ComponentTests/FSharpChecker/TransparentCompiler.fs
majocha
majocha commented Nov 7, 2024
View reviewed changes
Comment threadtests/FSharp.Compiler.Service.Tests/MultiProjectAnalysisTests.fs
majocha
majocha commented Nov 7, 2024
View reviewed changes
Comment threadtests/FSharp.Compiler.Service.Tests/MultiProjectAnalysisTests.fs Outdated
0101
0101 approved these changes Nov 7, 2024
View reviewed changes

@01010101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this Jakub!!

Comment threadtests/FSharp.Compiler.ComponentTests/FSharpChecker/TransparentCompiler.fs
Comment threadtests/FSharp.Compiler.Service.Tests/ProjectAnalysisTests.fs Outdated
0101
0101 reviewed Nov 7, 2024
View reviewed changes
Comment threadtests/FSharp.Compiler.Service.Tests/ProjectAnalysisTests.fs Outdated
@majocha

majocha commented Nov 7, 2024

Copy link
Copy Markdown
ContributorAuthor

I added one overlooked fix. I think it's good when green.

@0101
0101 merged commit a88665c into dotnet:mainNov 9, 2024
@Martin521

Martin521 commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

I've got CompilerService.AsyncMemoize.Stress test and CompilerService.AsyncMemoize.Cancel running jobs with the same key failing here, only in the "Linux" test. Locally all runs fine (on Linux).
I will observe if this happens again, but thought I mention it already here (where the test was recently re-enabled)

@majocha

majocha commented Nov 28, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks Martin! I hope #18074 will fix it.

@dotnet-botdotnet-bot mentioned this pull request Nov 30, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@010101010101 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-enable transparent compiler tests, when stable

4 participants

@majocha@Martin521@0101@T-Gro