Uh oh!
There was an error while loading. Please reload this page.
Completion: fix qualified completion in sequence expressions - #18111
Merged
Conversation
Contributor
❗ Release notes required
|
T-Gro
reviewed
Dec 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
approved these changes
Dec 6, 2024
auduchinokforce-pushed
the
completion/seqExpr-qualifier
branch
2 times, most recently
from
December 6, 2024 14:36
28016cd to
6299e69Compareauduchinokforce-pushed
the
completion/seqExpr-qualifier
branch
from
December 10, 2024 14:21
6299e69 to
886a003Compareauduchinokforce-pushed
the
completion/seqExpr-qualifier
branch
from
December 10, 2024 14:22
886a003 to
8487881Compareauduchinok
commented
Dec 10, 2024
MemberAuthor
This has been green for a while, but the release notes constantly need resolving conflicts. |
psfinaki
commented
Dec 10, 2024
Contributor
Yeah release notes conflicts can be annoying, tho we sometimes resolve them to keep PRs in shape :) This LGTM, I was just also wondering about what Brian mentioned above. |
psfinaki
approved these changes
Dec 10, 2024
MemberAuthor
Can this be merged? :) |
T-Gro
enabled auto-merge (squash)
December 18, 2024 19:40
vzarytovskii
approved these changes
Dec 18, 2024
This was referenced Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#18033. I'm not entirely sure what the removed lines were intended to do, so maybe removing the reverts the fix introduced in #16882. The test added in #16882 passes for locally with this change.