Uh oh!
There was an error while loading. Please reload this page.
Skip signing VisualFsharp.sln and FSharp.sln when building with .NET … - #18113
Conversation
✅ No release notes required |
ellahathaway
commented
Dec 10, 2024
Marking this as ready for review. This change is needed to unblock dotnet/sdk#44855. Depending on the feedback to #18112 (comment), I'm happy to either revise this PR or open a follow up PR later. |
ellahathaway
commented
Dec 11, 2024
@dotnet/fsharp-team-msft - friendly ping. Can I please get eyes on this? It's needed to enable signing in the VMR for the unified build project. |
Uh oh!
There was an error while loading. Please reload this page.
psfinaki
commented
Dec 12, 2024
@ellahathaway sorry for the delay. We are waiting for @KevinRansom to take a look at this as he's most knowledgeable in the topic. If this is in a hurry && low risk, we can probably merge it as is and hope things work out. Letting @T-Gro to decide tho. |
KevinRansom
commented
Dec 12, 2024
@ellahathaway sorry for the delay I was in England. But now Jet-lag has my attention. |
Closes#18112
May need to be adjusted based on #18112 (comment)
When
VisualFSharp.slnandFSharp.slnare built with .NET Core MSBuild, no artifacts are built that can be signed -> signing fails when an emptyItemsToSignlist.This PR includes a change that sets
-signto false when buildingVisualFSharp.slnorFSharp.slnwith .NET Core on windows.