Uh oh!
There was an error while loading. Please reload this page.
Sink: report SynPat.ArrayOrList type - #18127
Conversation
❗ Release notes required
|
T-Gro
commented
Dec 10, 2024
Is this the right place? What is the intended type hint usage please? It does feel adhoc here because none of the other patterns (records, tupes, ..) is making a sink report, hence my question. |
DedSec256
commented
Dec 11, 2024
It seems there is no common place where we can add a sink and enable it for records/tuples/etc., but not include it in unnecessary (at least for now) patterns such as The difference between hints for the collection pattern is that for records/tuples/etc. annotations are usually shown for fields or tuple elements individually, while collections don't have elements at all (if this is the case |
T-Gro
commented
Dec 11, 2024
Thanks Alex, I get it now with your last paragraph. |
* Backport :: Bugfix :: Support `ldelem.u8`, `ldelem.u` opcode aliases (#18081) (#18096) * Streamlining test deps a bit (#18022) * Streamlining test deps a bit * up * Format ILVerify output a bit (#18120) * fix for race condition in FileIndex.fileIndexOfFile (#18008) * fix for race condition in FileIndex.fileIndexOfFile * fantomas * fixed ilverify baselines (just a single line number changed) * add release notes entry * FileToIndex: Added unlocked read so that lock is entered for new files only * update ilverify baselines (changed line numbers only) * Fix ILVerify --------- Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> * Update F# build version to 200 * Fix how much is trimmed from an interp string part (#18123) * Fix how much is trimmed from an interp string part Only trim last 2 characters if they are "%s" and the '%' is not escaped * Add release note --------- Co-authored-by: Adam Boniecki <abonie@users.noreply.github.com> * Sink: report SynPat.ArrayOrList type (#18127) --------- Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Martin <29605222+Martin521@users.noreply.github.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com> Co-authored-by: Adam Boniecki <abonie@users.noreply.github.com> Co-authored-by: Alex Berezhnykh <alexey.berezhnykh@jetbrains.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>

Reports the inferred
SynPat.ArrayOrListtype to the sink. This can be used in features like type hints.