Skip to content

Fix GraphNode deadlock - #18178

Merged
T-Gro merged 1 commit into
dotnet:mainfrom
majocha:buildgraph-cancel
Jan 2, 2025
Merged

Fix GraphNode deadlock#18178
T-Gro merged 1 commit into
dotnet:mainfrom
majocha:buildgraph-cancel

Conversation

@majocha

@majochamajocha commented Dec 28, 2024

Copy link
Copy Markdown
Contributor

Description

Fix the deadlock by replacing the continuation with a simple await. Also simplify the code a bit.

Fixes#18115

Checklist

  • Tested by running 1000 iterations locally but it should be apparent in the CI if the fix really works.
  • Performance should be unchanged or a bit better because of less indirect code.
  • Release notes entry updated

@majocha
majocha requested a review from a team as a code ownerDecember 28, 2024 10:26
@github-actions

github-actionsBot commented Dec 28, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jan 2, 2025
@T-Gro
T-Gro merged commit b1659a1 into dotnet:mainJan 2, 2025
This was referenced Jan 8, 2025
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@010101010101 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rare deadlock in GraphNode.GetOrComputeValue

3 participants

@majocha@0101@T-Gro