Uh oh!
There was an error while loading. Please reload this page.
Improve directory attribute refactor - Break up PR #18161 - Part 1 - #18195
Merged
psfinaki merged 3 commits intoJan 7, 2025
Conversation
Contributor
✅ No release notes required |
KevinRansomforce-pushed
the
ImproveDirectoryAttribute.Refactor
branch
from
January 3, 2025 00:06
e0b845d to
e2b0db7CompareT-Gro
reviewed
Jan 3, 2025
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
reviewed
Jan 3, 2025
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
reviewed
Jan 3, 2025
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
approved these changes
Jan 3, 2025
T-Gro
left a comment
Member
There was a problem hiding this comment.
Could you please post an assurance that the number of tests executed is the same or higher?
psfinaki
reviewed
Jan 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
KevinRansomforce-pushed
the
ImproveDirectoryAttribute.Refactor
branch
from
January 6, 2025 23:55
5a026a0 to
60bfdd0CompareKevinRansomforce-pushed
the
ImproveDirectoryAttribute.Refactor
branch
from
January 7, 2025 01:14
60bfdd0 to
966733fCompareKevinRansom
commented
Jan 7, 2025
ContributorAuthor
|
psfinaki
approved these changes
Jan 7, 2025
psfinaki
left a comment
Contributor
There was a problem hiding this comment.
That's nice and very helpful, thanks!
psfinaki
commented
Jan 7, 2025
Contributor
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks up the directory attribute refactor, which is enormous.
This inital PR contains the test framework code changes.
And 1 quite large folder of test cases that use baselines a fair amount.
/cc @T-Gro