Skip to content

Handle some flaky ProjectAnalysisTests cases - #18200

Merged
T-Gro merged 3 commits into
dotnet:mainfrom
majocha:Fix-flaky-test
Jan 6, 2025
Merged

Handle some flaky ProjectAnalysisTests cases#18200
T-Gro merged 3 commits into
dotnet:mainfrom
majocha:Fix-flaky-test

Conversation

@majocha

Copy link
Copy Markdown
Contributor

Description

Test cases utilizing Project25 do not like to run concurrently with each other. Probably because of the XmlProvider here:

moduleinternalProject25 =
letfileName1= Path.ChangeExtension(getTemporaryFileName (),".fs")
letbase2= getTemporaryFileName ()
letdllName= Path.ChangeExtension(base2,".dll")
letprojFileName= Path.ChangeExtension(base2,".fsproj")
letfileSource1="""
module TypeProviderTests
open FSharp.Data
type Project = XmlProvider<"<root><value>1</value><value>3</value></root>">

I verified locally by running some iterations that marking the affected test cases with RunTestCasesInSequence resolves the problem.

@majocha
majocha requested a review from a team as a code ownerJanuary 3, 2025 13:40
@github-actions

Copy link
Copy Markdown
Contributor

✅ No release notes required

@majochamajocha closed this Jan 3, 2025
@majochamajocha reopened this Jan 3, 2025
@T-Gro
T-Gro enabled auto-merge (squash) January 6, 2025 10:30
0101
0101 approved these changes Jan 6, 2025
@psfinaki

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki

Copy link
Copy Markdown
Contributor

This PR is particularly unlucky...

@majocha

Copy link
Copy Markdown
ContributorAuthor

Ah, this particular failure is unrelated but a genuine bug. I'll sort it out.

@T-Gro
T-Gro merged commit ded0349 into dotnet:mainJan 6, 2025
@psfinaki

Copy link
Copy Markdown
Contributor

Thanks @majocha for your continuous interest 😎

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@majocha@psfinaki@0101@T-Gro