Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary overrides in TestConsole - #18208
Merged
Merged
Conversation
Contributor
✅ No release notes required |
T-Gro
approved these changes
Jan 8, 2025
T-Gro
enabled auto-merge (squash)
January 8, 2025 08:56
psfinaki
commented
Jan 8, 2025
Contributor
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when experimenting with adding
--timesoption in tests I noticed newlines sometimes disappear in captured console output.Removing these overrides fixes it.
There should be no noticeable slow-down. Arguably it is worth it just to reduce complexity.