Skip to content

Update Obsolete attribute checking to account for diagnosticId and urlFormat properties - #18224

Merged
T-Gro merged 16 commits into
dotnet:mainfrom
edgarfgp:fix-8654
Jan 20, 2025
Merged

Update Obsolete attribute checking to account for diagnosticId and urlFormat properties#18224
T-Gro merged 16 commits into
dotnet:mainfrom
edgarfgp:fix-8654

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Jan 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes#8654

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Jan 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.300.md

edgarfgp
edgarfgp commented Jan 10, 2025
View reviewed changes
Comment threadsrc/Compiler/Symbols/FSharpDiagnostic.fs
@edgarfgp
edgarfgp marked this pull request as ready for review January 10, 2025 20:58
@edgarfgp
edgarfgp requested a review from a team as a code ownerJanuary 10, 2025 20:58
psfinaki
psfinaki reviewed Jan 14, 2025
View reviewed changes
Comment threadsrc/Compiler/Checking/AttributeChecking.fs
psfinaki
psfinaki reviewed Jan 14, 2025
View reviewed changes
Comment threaddocs/release-notes/.FSharp.Compiler.Service/9.0.300.md
T-Gro
T-Gro reviewed Jan 15, 2025
View reviewed changes
Comment threadsrc/Compiler/Checking/AttributeChecking.fs Outdated
@edgarfgp
edgarfgp requested a review from T-GroJanuary 20, 2025 09:20
@T-Gro
T-Gro enabled auto-merge (squash) January 20, 2025 15:05
@T-Gro
T-Gro merged commit 4b676b4 into dotnet:mainJan 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+2 more reviewers
@psfinakipsfinakipsfinaki left review comments
@KevinRansomKevinRansomKevinRansom approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Honor new properties on ObsoleteAttribute for .NET 5

4 participants

@edgarfgp@KevinRansom@psfinaki@T-Gro