Set Cancellable.token from async computation

[majocha]

Fixes#18235

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

[majocha]

@auduchinok pls take a look.

Searching for ILModuleDef I see there are a few other calls that are not obvious for me. So this may not fix the problem entirely.

[majocha]

I wonder if we could remove the cancellable CE altogether and just capture the cancellation token into AsyncLocal at all async service endpoints instead.

[auduchinok]

I wonder if we could remove the cancellable CE altogether and just capture the cancellation token into AsyncLocal at all async service endpoints instead.

Sounds good! I think @vzarytovskii had a similar idea some time ago.

[majocha]

I wonder if we could remove the cancellable CE altogether and just capture the cancellation token into AsyncLocal at all async service endpoints instead.

Sounds good! I think @vzarytovskii had a similar idea some time ago.

That would probably require converting all the cancellable uses to async, keeping in sight the goal of replacing async with more performant resumable CE with better stack traces (?).

[auduchinok]

@majocha This is from the same test with this PR applied:

System.Exception: Token not available outside of Cancellable computation.
at <StartupCode$FSharp-Compiler-Service>.$Cancellable.defThunk@1(String msg, Unit unitVar0) in C:\Developer\jetbrains-fcs\src\Compiler\Utilities\Cancellable.fs:line 15
at FSharp.Compiler.Cancellable.ensureToken(String msg) in C:\Developer\jetbrains-fcs\src\Compiler\Utilities\Cancellable.fs:line 14
at FSharp.Compiler.Cancellable.get_Token() in C:\Developer\jetbrains-fcs\src\Compiler\Utilities\Cancellable.fs:line 19
at JetBrains.ReSharper.Plugins.FSharp.FSharpAsyncUtil.UsingReadLockInsideFcs(IShellLocks locks, Action action, Func`1 upToDateCheck) in C:\Developer\resharper-fsharp\ReSharper.FSharp\src\FSharp\FSharp.ProjectModelBase\src\FSharpAsyncUtil.cs:line 40
at JetBrains.ReSharper.Plugins.FSharp.Shim.AssemblyReader.ProjectFcsModuleReader.readData(FSharpFunc`2 f) in C:\Developer\resharper-fsharp\ReSharper.FSharp\src\FSharp\FSharp.Common\src\Shim\AssemblyReader\ProjectFcsModuleReader.fs:line 142
at JetBrains.ReSharper.Plugins.FSharp.Shim.AssemblyReader.ProjectFcsModuleReader.CreateTypeDef(IClrTypeName clrTypeName) in C:\Developer\resharper-fsharp\ReSharper.FSharp\src\FSharp\FSharp.Common\src\Shim\AssemblyReader\ProjectFcsModuleReader.fs:line 1273
at JetBrains.ReSharper.Plugins.FSharp.Shim.AssemblyReader.PreTypeDef.FSharp.Compiler.AbstractIL.IL.ILPreTypeDef.GetTypeDef() in C:\Developer\resharper-fsharp\ReSharper.FSharp\src\FSharp\FSharp.Common\src\Shim\AssemblyReader\ProjectFcsModuleReader.fs:line 1484
at FSharp.Compiler.Import.entities@784-1.Invoke(Tuple`2 tupledArg) in C:\Developer\jetbrains-fcs\src\Compiler\Checking\import.fs:line 786
at FSharp.Compiler.Import.multisetDiscriminateAndMap[Key,Value,a](FSharpFunc`2 nodef, FSharpFunc`2 tipf, FSharpList`1 items) in C:\Developer\jetbrains-fcs\src\Compiler\Checking\import.fs:line 726
at FSharp.Compiler.Import.ImportILTypeDefList(FSharpFunc`2 amap, Range m, CompilationPath cpath, FSharpList`1 enc, FSharpList`1 items) in C:\Developer\jetbrains-fcs\src\Compiler\Checking\import.fs:line 779
at FSharp.Compiler.Import.ImportILTypeDefs(FSharpFunc`2 amap, Range m, ILScopeRef scoref, CompilationPath cpath, FSharpList`1 enc, ILTypeDefs tdefs) in C:\Developer\jetbrains-fcs\src\Compiler\Checking\import.fs:line 796
at FSharp.Compiler.Import.ImportILAssemblyMainTypeDefs(FSharpFunc`2 amap, Range m, ILScopeRef scoref, ILModuleDef modul) in C:\Developer\jetbrains-fcs\src\Compiler\Checking\import.fs:line 806
at FSharp.Compiler.Import.ImportILAssemblyTypeDefs(FSharpFunc`2 amap, Range m, FSharpFunc`2 auxModLoader, ILAssemblyRef aref, ILModuleDef mainmod) in C:\Developer\jetbrains-fcs\src\Compiler\Checking\import.fs:line 842
at FSharp.Compiler.Import.ImportILAssembly(FSharpFunc`2 amap, Range m, FSharpFunc`2 auxModuleLoader, FSharpOption`1 xmlDocInfoLoader, ILScopeRef ilScopeRef, String sourceDir, FSharpOption`1 fileName, ILModuleDef ilModule, IEvent`2 invalidateCcu) in C:\Developer\jetbrains-fcs\src\Compiler\Checking\import.fs:line 908
at FSharp.Compiler.CompilerImports.TcImports.PrepareToImportReferencedILAssembly(CompilationThreadToken ctok, Range m, String fileName, ImportedBinary dllinfo) in C:\Developer\jetbrains-fcs\src\Compiler\Driver\CompilerImports.fs:line 2058
at FSharp.Compiler.CompilerImports.TryRegisterAndPrepareToImportReferencedDll@2279-8.Invoke(IRawFSharpAssemblyData assemblyData) in C:\Developer\jetbrains-fcs\src\Compiler\Driver\CompilerImports.fs:line 2316
at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, b result1, FSharpFunc`2 userCode) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 528
at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 112

[majocha]

Yes, I have another idea. Just define Cancellable.UseToken: Async<unit> that will sync the Cancellable token with current async token.

[auduchinok]

@majocha Yes, with this patch all the tests are green 🎉

[psfinaki]

Thanks!