Skip to content

More OpenTelemetry changes - #18246

Merged
psfinaki merged 16 commits into
dotnet:mainfrom
majocha:otel
Feb 10, 2025
Merged

More OpenTelemetry changes#18246
psfinaki merged 16 commits into
dotnet:mainfrom
majocha:otel

Conversation

@majocha

@majochamajocha commented Jan 18, 2025

Copy link
Copy Markdown
Contributor
  • Add activity wrapping a test run to easily distinguish traces generated from testhost. Group by assembly + net framework.
  • log point-in-time events as events with data instead of activities to declutter traces. (for example StackGuard.Guard)
  • Enable trace provider in vsix when build in debug configuration: For example build VisualFSharpDebug in debug mode and start an instance with "Start WIthout Debugging" will produce traces viewable in Jeager.

Captured test run, some tests in parallel, a theory runs sequentially, Stackguard events with tags:
image

Traces from running VS instance:
image

@github-actions

github-actionsBot commented Jan 18, 2025

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

Comment threadvsintegration/src/FSharp.Editor/FSharp.Editor.fsproj Outdated
Comment threadsrc/Compiler/Facilities/DiagnosticsLogger.fs
@majocha

Copy link
Copy Markdown
ContributorAuthor

Slightly less allocations.

main:

MethodMeanErrorStdDevGen0Gen1Gen2Allocated
ParseAndCheckFileInProject1.654 s0.0225 s0.0199 s10000.00005000.00001000.00001.96 GB

this PR:

MethodMeanErrorStdDevGen0Gen1Gen2Allocated
ParseAndCheckFileInProject1.625 s0.0302 s0.0297 s9000.00004000.00001000.00001.91 GB

@majocha
majocha marked this pull request as ready for review January 29, 2025 23:19
@majocha
majocha requested a review from a team as a code ownerJanuary 29, 2025 23:19
Comment threadsrc/Compiler/Utilities/Activity.fsi
@psfinaki

Copy link
Copy Markdown
Contributor

As with other OT changes, any Jaeger screenshots would be nice to have :)

@psfinaki

Copy link
Copy Markdown
Contributor

Hi @majocha would you like to add something else here or is it getting ready to merge?

@majocha

Copy link
Copy Markdown
ContributorAuthor

@psfinaki I think it's ok. Don't know how useful this will be in general, but it does reduce allocations a bit.

@psfinaki

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinakipsfinaki added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Feb 10, 2025
@psfinaki
psfinaki merged commit 5d0812f into dotnet:mainFeb 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@majocha@psfinaki@0101@T-Gro