Skip to content

Add support for C# Experimental attribute - #18253

Merged
T-Gro merged 14 commits into
dotnet:mainfrom
edgarfgp:fix-18198
Feb 10, 2025
Merged

Add support for C# Experimental attribute#18253
T-Gro merged 14 commits into
dotnet:mainfrom
edgarfgp:fix-18198

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Jan 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes#18198

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Jan 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@edgarfgpedgarfgp changed the title Add support C# Experimental attributeAdd support for C# Experimental attributeJan 20, 2025
@edgarfgp
edgarfgp marked this pull request as ready for review January 22, 2025 22:04
@edgarfgp
edgarfgp requested a review from a team as a code ownerJanuary 22, 2025 22:04
T-Gro
T-Gro reviewed Jan 23, 2025
View reviewed changes
Comment threadsrc/Compiler/Driver/CompilerDiagnostics.fs Outdated
T-Gro
T-Gro reviewed Jan 23, 2025
View reviewed changes
Comment threadsrc/Compiler/Symbols/FSharpDiagnostic.fs Outdated
T-Gro
T-Gro reviewed Jan 23, 2025
View reviewed changes
Comment threadsrc/Compiler/Facilities/DiagnosticsLogger.fs Outdated
@KevinRansom

KevinRansom commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

Is there some reason this is insufficient?

https://github.com/dotnet/fsharp/blob/main/src/FSharp.Core/prim-types.fs#L265

@T-Gro

T-Gro commented Jan 24, 2025

Copy link
Copy Markdown
Member

Is there some reason this is insufficient?

https://github.com/dotnet/fsharp/blob/main/src/FSharp.Core/prim-types.fs#L265

@edgarfgp added support for detecting the same attribute which was added in .NET / supported by C#12+ - https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-12.0/experimental-attribute

@edgarfgp
edgarfgp requested a review from T-GroJanuary 29, 2025 09:11
psfinaki
psfinaki reviewed Feb 6, 2025
View reviewed changes
Comment threadsrc/Compiler/Checking/AttributeChecking.fs Outdated
psfinaki
psfinaki reviewed Feb 6, 2025
View reviewed changes
Comment threadsrc/Compiler/Driver/CompilerDiagnostics.fs Outdated
@edgarfgpedgarfgp closed this Feb 9, 2025
@edgarfgpedgarfgp reopened this Feb 9, 2025
@T-Gro
T-Gro enabled auto-merge (squash) February 10, 2025 11:38
psfinaki
psfinaki approved these changes Feb 10, 2025
View reviewed changes

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks Edgar!

@T-Gro
T-Gro merged commit 8e773e7 into dotnet:mainFeb 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@psfinakipsfinakipsfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

F# compiler does not respect ExperimentalAttribute

4 participants

@edgarfgp@KevinRansom@T-Gro@psfinaki