Uh oh!
There was an error while loading. Please reload this page.
Cancellable: remove UsingToken usages in tests - #18276
Conversation
✅ No release notes required |
auduchinok
commented
Jan 28, 2025
So, just removing the member from the public API didn't work, as it was used in |
majocha
commented
Jan 28, 2025
@auduchinok I'm not sure about removing inline there, would it affect stack traces and debugging? Somewhat related: It would be great to integrate the functionality of |
54bf644 to
f41696eCompareThe token is now always set inside the cancellable computation
f41696e to
91ef654Comparemajocha
commented
Jan 30, 2025
So, I did some benchmark runs using FCSSourceFiles benchmark and frankly I see no difference between inlined and not inlined /// Run a cancellable computation using the given cancellation tokenlet inlinerun(ct:CancellationToken)(Cancellable oper)=if ct.IsCancellationRequested then
ValueOrCancelled.Cancelled(OperationCanceledException ct)else
oper ctit seems the idea was to just expand the cancel check inline. |
psfinaki
commented
Jan 30, 2025
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Removes
Cancellable.UsingTokenfrom the public surface, since the computation now always sets the token.