Skip to content

Add missing project reference from FSharpSuite to fsc project - #18291

Merged
psfinaki merged 2 commits into
mainfrom
fsharpsuite-add-projectreference-fcs
Feb 5, 2025
Merged

Add missing project reference from FSharpSuite to fsc project#18291
psfinaki merged 2 commits into
mainfrom
fsharpsuite-add-projectreference-fcs

Conversation

@T-Gro

@T-GroT-Gro commented Feb 4, 2025

Copy link
Copy Markdown
Member

FSharpSuite uses fsc by .exe invocation.

This project reference ensures that fsc is invalidated when compiler changes are present.
That way, running tests from VS will not risk using stale fsc.exe executable.

@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Feb 4, 2025
@T-Gro
T-Gro requested a review from a team as a code ownerFebruary 4, 2025 13:08
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro

T-Gro commented Feb 4, 2025

Copy link
Copy Markdown
MemberAuthor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

0101
0101 approved these changes Feb 4, 2025
@psfinaki
psfinaki merged commit 5ef029b into mainFeb 5, 2025
@T-Gro
T-Gro deleted the fsharpsuite-add-projectreference-fcs branch February 10, 2025 10:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@T-Gro@0101@KevinRansom@psfinaki