Uh oh!
There was an error while loading. Please reload this page.
Cancellable: hide UsingToken and simplify inlined run - #18309
Merged
Conversation
Contributor
|
majochaforce-pushed
the
cancellable-using-token
branch
from
February 11, 2025 15:39
d60cae3 to
a67facdCompareT-Gro
reviewed
Feb 12, 2025
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Cancellable.runfunction gets inlined quite a lot so it may be beneficial to simplify it.UsingTokenis not used anymore outside of the file, can be private.cc @auduchinok