Skip to content

[main] Update dependencies from dotnet/msbuild - #18363

Merged
psfinaki merged 16 commits into
mainfrom
darc-main-e82e7809-0231-4bcd-a79d-6ec19871b7ba
Mar 17, 2025
Merged

[main] Update dependencies from dotnet/msbuild#18363
psfinaki merged 16 commits into
mainfrom
darc-main-e82e7809-0231-4bcd-a79d-6ec19871b7ba

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Mar 6, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/msbuildbuild 2025…
afbe428
…0306.7
Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core
From Version 17.11.0-preview-24178-03 -> To Version 17.14.0-preview-25156-07
@dotnet-maestro
dotnet-maestroBot requested a review from a team as a code ownerMarch 6, 2025 12:50
@github-actions

github-actionsBot commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

✅ No release notes required

@psfinaki
psfinaki requested a review from a team as a code ownerMarch 7, 2025 10:59
@psfinaki

psfinaki commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Hi @ellahathaway and @mthalman. So I am trying to apply what you mentioned in this PR - I've set up a new Maestro subscription to flow msbuild to our repo, which produced this PR.

Good news is that I could remove the recently added lines from SourceBuildPrebuiltBaseline.xml.

But - the new MSBuild version claimed the updates to the System packages which, in turn, SourceBuild is now complaining about:

Package IDs are:
System.Collections.Immutable.9.0.0
System.Configuration.ConfigurationManager.9.0.0
System.Diagnostics.DiagnosticSource.9.0.0
System.Diagnostics.EventLog.9.0.0
System.Formats.Asn1.9.0.0
System.Formats.Nrbf.9.0.0
System.Reflection.Metadata.9.0.0
System.Resources.Extensions.9.0.0
System.Security.Cryptography.ProtectedData.9.0.0
System.Text.Encoding.CodePages.9.0.0
System.Threading.Tasks.Dataflow.9.0.0

What's your recommendation? Should I add those to the baseline - like Roslyn has that? Should I do something else?

mthalman
mthalman reviewed Mar 7, 2025
View reviewed changes
Comment threadeng/Version.Details.xml
dotnet-maestroBotand others added 2 commits March 8, 2025 05:02
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/msbuildbuild 2025…
0ffd392
…0307.7
Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core
From Version 17.11.0-preview-24178-03 -> To Version 17.14.0-preview-25157-07
@psfinaki
Update Version.Details.xml
ce41cba
@T-Gro

T-Gro commented Mar 10, 2025

Copy link
Copy Markdown
Member

I don't think it's correct for us to depend on preview versions in our versions.props - those bits are flowing automatically to release branches, and consequently, insertions.

I don't think I have seen preview versions for those components in versions.props before, so we should only do it if it gives any sensible advantage (e.g. compared to taking last known good stable versions).

A source build specific config can of course do whatever source build requires, I do understand that.

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/msbuildbuild 2025…
b40b689
…0310.8
Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core
From Version 17.11.0-preview-24178-03 -> To Version 17.14.0-preview-25160-08
@psfinaki

psfinaki commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

@T-Gro I get your perspective and I personally don't have any big preference here.

That said, note that we actually do have preview packages among our dependencies, e.g. this and this.

It's not uncommon for sibling repos to have preview deps as well, e.g. ASP.NET Core has the hell lot of them.

That was the reason for my choice. However, it's trivial to resetup this in Maestro, if we want to.

@T-Gro

T-Gro commented Mar 11, 2025

Copy link
Copy Markdown
Member

@T-Gro I get your perspective and I personally don't have any big preference here.

That said, note that we actually do have preview packages among our dependencies, e.g. this and this.

It's not uncommon for sibling repos to have preview deps as well, e.g. ASP.NET Core has the hell lot of them.

That was the reason for my choice. However, it's trivial to resetup this in Maestro, if we want to.

None of the links, neither this repo nor aspnetcore, are making it to be part of the shipped product.
This is not really about preference - it is about being aware what is being a shippable production product.

If you can ensure that the preview versions remain in main only and release branches will have stable versions, that works.
(if the benefits are really that big and additional complexity+cost is justified)

dotnet-maestroBotand others added 4 commits March 12, 2025 05:01
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/msbuildbuild 2025…
727fdd5
…0311.14
Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core
From Version 17.11.0-preview-24178-03 -> To Version 17.14.0-preview-25161-14
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/msbuildbuild 2025…
79db0ed
…0228.1
Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core
From Version 17.11.0-preview-24178-03 -> To Version 17.13.19-preview-25128-01
@psfinaki
Update
2489c88
@psfinaki
up
c6c2c70
@psfinaki

psfinaki commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Okay @mthalman@ellahathaway this should be good to go, I set up Maestro to not send previews to us, which in turn now doesn't require System packages update. As the result, this only removes stuff from SourceBuildPrebuildBaseline without adding anything there - which is nice.

@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingMar 12, 2025
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/msbuildbuild 2025…
dcaf112
…0312.14
Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core
From Version 17.11.0-preview-24178-03 -> To Version 17.13.20-preview-25162-14
@psfinaki
psfinaki enabled auto-merge (squash) March 13, 2025 11:59
@psfinaki
psfinaki disabled auto-merge March 13, 2025 11:59
@psfinaki

psfinaki commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

/azp run

@psfinaki
psfinaki enabled auto-merge (squash) March 17, 2025 12:34
@azure-pipelines

azure-pipelinesBot commented Mar 17, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
psfinaki merged commit 4dc458c into mainMar 17, 2025
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in F# Compiler and ToolingMar 17, 2025
@dotnet-maestro
dotnet-maestroBot deleted the darc-main-e82e7809-0231-4bcd-a79d-6ec19871b7ba branch March 17, 2025 14:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mthalmanmthalmanmthalman approved these changes
@T-GroT-GroT-Gro approved these changes
@ellahathawayellahathawayellahathaway approved these changes
+1 more reviewer
@psfinakipsfinakipsfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@psfinaki@T-Gro@mthalman@ellahathaway