Skip to content

Fix resumable and non-resumable CE error ranges - #18450

Merged
T-Gro merged 20 commits into
dotnet:mainfrom
edgarfgp:fix-13789
Apr 14, 2025
Merged

Fix resumable and non-resumable CE error ranges#18450
T-Gro merged 20 commits into
dotnet:mainfrom
edgarfgp:fix-13789

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

Description

BEFORE

Screenshot 2025-04-05 at 20 31 20

AFTER

openSystem.Threading.Tasksletminimum():Async<int>=async{let!batch=async{return1}return"1"^^^}letminimum():Task<int>=task{let!batch=task{return1}return"1"^^^}

Fixes#13789

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

Updated the baselines locally and all test are passing. But the CI is not reflecting the same. Any tips @psfinaki ?

@psfinaki

Copy link
Copy Markdown
Contributor

@edgarfgp yes :) I've checked out your branch.

The thing is that you're most likely running tests locally in the Debug mode (where they indeed pass) whereas the CI executes them in Release mode (where they fail locally as well). You're nearly there!

@edgarfgp
edgarfgp marked this pull request as ready for review April 7, 2025 20:35
@edgarfgp
edgarfgp requested a review from a team as a code ownerApril 7, 2025 20:35
@T-Gro
T-Gro enabled auto-merge (squash) April 11, 2025 10:59
@edgarfgp
edgarfgp requested a review from psfinakiApril 14, 2025 10:52

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks Edgar :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Confusing type inference error in task expression

4 participants

@edgarfgp@psfinaki@brianrourkeboll@T-Gro