Skip to content

More test for error recovery - #18669

Merged
T-Gro merged 29 commits into
dotnet:mainfrom
edgarfgp:more-test-for-error-recovery
Jun 17, 2025
Merged

More test for error recovery #18669
T-Gro merged 29 commits into
dotnet:mainfrom
edgarfgp:more-test-for-error-recovery

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Jun 6, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add extra test to showcase how the error recovery was improved in #18645

Thanks to @auduchinok for requesting this and to Claude for helping with the test names. :)

Checklist

  • Test cases added
  • Release notes entry updated

edgarfgpand others added 24 commits April 23, 2025 15:27
@edgarfgp
make attribute targets mismatches a warning and not an error.
1799aaf
@edgarfgp
release notes
55507e9
@edgarfgp
update tests
1738018
@edgarfgp
Merge branch 'main' into fix-attr-targets
65f5bb6
@edgarfgp
Merge branch 'main' into fix-attr-targets
0c97b9d
@edgarfgp
update baselines
6f2b706
@edgarfgp
Merge branch 'main' into fix-attr-targets
e8f1bb0
@edgarfgp
Update baselines
75d8f5e
@edgarfgp
Merge branch 'fix-attr-targets' of github.com:edgarfgp/fsharp into fi…
4f2e97e
…x-attr-targets
@edgarfgp
Merge branch 'main' into fix-attr-targets
63be5d5
@edgarfgp
Move attribute form logic to an AP
4248f2a
@edgarfgp
Merge branch 'main' into fix-attr-targets
cc96217
@edgarfgp
Merge branch 'main' into fix-attr-targets
e270b88
@edgarfgp
Merge branch 'main' into fix-attr-targets
e0cc65a
@edgarfgp
Merge branch 'main' into fix-attr-targets
1e29d58
@edgarfgp
Merge branch 'main' into fix-attr-targets
1470bf9
@edgarfgp
Merge branch 'main' into fix-attr-targets
8988215
@edgarfgp
Merge branch 'main' into fix-attr-targets
74712e8
@edgarfgp
Merge branch 'main' of github.com:edgarfgp/fsharp
967c4a9
@edgarfgp
Merge branch 'dotnet:main' into main
a30cef4
@edgarfgp
Merge branch 'dotnet:main' into main
5fa0480
@edgarfgp
Merge branch 'dotnet:main' into main
15e3d34
@edgarfgp
Merge branch 'dotnet:main' into main
b7ffcf8
@edgarfgp
Add error recovery tests
fbb5679
@edgarfgpedgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jun 6, 2025
@edgarfgp
edgarfgp requested a review from auduchinokJune 6, 2025 14:57
@github-actions

github-actionsBot commented Jun 6, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@edgarfgp
edgarfgp marked this pull request as ready for review June 6, 2025 14:58
@edgarfgp
edgarfgp requested a review from a team as a code ownerJune 6, 2025 14:58
auduchinok
auduchinok reviewed Jun 6, 2025
View reviewed changes

@auduchinokauduchinok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarfgp Thanks a lot! I've added a few ideas about trying to make it a bit simpler

Comment threadtests/FSharp.Compiler.ComponentTests/ErrorMessages/AbbreviationTests.fs Outdated
Comment threadtests/FSharp.Compiler.ComponentTests/ErrorMessages/AbbreviationTests.fs Outdated
Comment threadtests/FSharp.Compiler.ComponentTests/ErrorMessages/AbbreviationTests.fs Outdated
T-Gro
T-Gro approved these changes Jun 9, 2025
View reviewed changes

@T-GroT-Gro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition.
I agree with @auduchinok on the naming - we can exclude name of the surrounding module/namespace, and make test names shorted.

(and I know that this isn't always met in existing tests, including the ones I have authored)

@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingJun 9, 2025
@edgarfgp
edgarfgp requested a review from T-GroJune 10, 2025 09:31
@edgarfgp

edgarfgp commented Jun 11, 2025

Copy link
Copy Markdown
ContributorAuthor

This is ready. I wanted to raise couple PR's regarding error recovery for CheckExpressions.fs

@edgarfgp

edgarfgp commented Jun 17, 2025

Copy link
Copy Markdown
ContributorAuthor

@T-Gro Can we merge this ?

@T-Gro
T-Gro merged commit 6d57e3b into dotnet:mainJun 17, 2025
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in F# Compiler and ToolingJun 17, 2025
T-Gro added a commit that referenced this pull request Jun 24, 2025
@T-Gro@edgarfgp
@dotnet-maestro@Smaug123@abonie
[automated] Merge branch 'main' => 'release/dev18.0' (#18711)
44a24dc
* More test for error recovery (#18669)
* [main] Update dependencies from dnceng/internal/dotnet-optimization (#18683)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250610.1
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25310.1
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250611.1
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25311.1
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250616.1
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25316.1
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250617.1
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25317.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
* [main] Update dependencies from dotnet/arcade (#18643)
* Expand docstring on SynModuleDecl.Types (#18698)
* Update dependencies from https://github.com/dotnet/arcade build 20250620.5 (#18703)
Microsoft.DotNet.Arcade.Sdk
From Version 10.0.0-beta.25316.2 -> To Version 10.0.0-beta.25320.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Remove feature/lsp merge from branch-merge.yml (#18705)
Cleaning up, sicne we've merged feature/lsp to main some time ago
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250623.1 (#18710)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
From Version 1.0.0-prerelease.25317.1 -> To Version 1.0.0-prerelease.25323.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20250623.3 (#18709)
Microsoft.DotNet.Arcade.Sdk
From Version 10.0.0-beta.25320.5 -> To Version 10.0.0-beta.25323.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Remove ActivityDisposable conditional directives and replace with System.IDisposable | null (#18707)
---------
Co-authored-by: Edgar Gonzalez <egonzalez@totallymoney.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Patrick Stevens <3138005+Smaug123@users.noreply.github.com>
Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
@dotnet-botdotnet-bot mentioned this pull request Jul 26, 2025
Closed
@dotnet-botdotnet-bot mentioned this pull request Aug 22, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroAwaiting requested review from T-Gro
1 more reviewer
@auduchinokauduchinokauduchinok left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarfgp@auduchinok@T-Gro