Uh oh!
There was an error while loading. Please reload this page.
Allow typed bindings(and!) in CE without parentheses - #18682
Merged
Conversation
Contributor
❗ Release notes required
|
and! typed bindingsT-Gro
reviewed
Jul 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
T-Gro
reviewed
Jul 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
edgarfgp
commented
Jul 28, 2025
ContributorAuthor
This is ready @T-Gro |
T-Gro
commented
Jul 29, 2025
Member
Thanks @edgarfgp for getting this in. |
T-Gro
approved these changes
Jul 29, 2025
edgarfgp
commented
Jul 29, 2025
ContributorAuthor
/azn run |
edgarfgp
commented
Jul 29, 2025
ContributorAuthor
Thanks @T-Gro. Can you please re-run the CI ?. Don't want to close a re-open the PR. |
T-Gro
commented
Jul 29, 2025
Member
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
T-Gro
enabled auto-merge (squash)
July 29, 2025 10:43
Uh oh!
There was an error while loading. Please reload this page.
2 tasks
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow computation expression (CE) bindings (
let!,use!,and!) to accept type annotations without requiring parentheses.Continuation of #18508
Implements RFC FS-1329: fsharp/fslang-design#802
Introduces significant grammar unification:
bindingPatternWithOptTypeandceBindingCoremkLetExpressionandmkAndBangAllowTypedLetUseAndBangThe above rule unification will allow us to remove in a separate PR
LetOrUseBang, adding boolenisComputedproperty(true for let!/use!, false for let/use) toLetOrUse.Checklist