Skip to content

Error on invalid declarations in type definitions. - #18813

Merged
T-Gro merged 70 commits into
dotnet:mainfrom
edgarfgp:fix-10066
Aug 26, 2025
Merged

Error on invalid declarations in type definitions.#18813
T-Gro merged 70 commits into
dotnet:mainfrom
edgarfgp:fix-10066

Conversation

@edgarfgp

@edgarfgpedgarfgp commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes#10066

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions

github-actionsBot commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/10.0.100.md
LanguageFeatures.fsidocs/release-notes/.Language/preview.md

Comment threadtests/service/data/SyntaxTree/Type/Module Inside Type Defn 03.fs Outdated
@edgarfgp
edgarfgpforce-pushed the fix-10066 branch 2 times, most recently from 082655a to 17e2f1cCompareAugust 15, 2025 10:10

@psfinakipsfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, as always Edgar :)

@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

@T-Gro Any chance I get some help updating the last failing .bsl tests. Im on a macOS and for some reason the use usual export TEST_UPDATE_BSL=1 & dotnet test does not work. Thanks

@edgarfgp

Copy link
Copy Markdown
ContributorAuthor

This is ready :)

@T-Gro
T-Gro enabled auto-merge (squash) August 25, 2025 14:58
@T-Gro

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro
T-Gro merged commit e513690 into dotnet:mainAug 26, 2025
38 checks passed
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in F# Compiler and ToolingAug 26, 2025
@edgarfgpedgarfgp mentioned this pull request Oct 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Compiler allows what looks like a module nested inside of a type, but isn't

7 participants

@edgarfgp@brianrourkeboll@Martin521@T-Gro@auduchinok@psfinaki