Uh oh!
There was an error while loading. Please reload this page.
FCS: allow getting captured types - #18878
Conversation
❗ Release notes required
|
7702a51 to
58581bdCompareauduchinok
commented
Sep 2, 2025
I'm stuck with the ILVerify tests due to #18289 again: Or when trying another shell, as suggested in the devguide: Could someone update the baselines here, please? |
T-Gro
commented
Sep 3, 2025
I think the script is (badly) written in a way that relies on having a specific current directory, otherwise it searches in wrong folders I will do it 👍 (I think those two things should make it smoother to execute) |
T-Gro
commented
Sep 3, 2025
/run ilverify |
🔧 CLI Command Report
✅ Patch applied: |
auduchinok
commented
Sep 9, 2025
This has been ready since last Tuesday. I'd like to continue to work on it in subsequent PRs, but this is getting stale. |
edgarfgp
commented
Sep 9, 2025
@auduchinok if its only to update the ilverify. Happy to send a PR to your fork. If so please fix the conflicts then I will try and run the ilverify on my machine and see if that helps |
# Conflicts: # tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.SurfaceArea.netstandard20.release.bsl
4441521 to
70f58e1Compareauduchinok
commented
Sep 12, 2025
@T-Gro Is there anything I could do to help in getting it reviewed/merged? |
edgarfgp
commented
Sep 12, 2025
Ping @vzarytovskii in case we can merge this. |
Uh oh!
There was an error while loading. Please reload this page.
vzarytovskii
left a comment
There was a problem hiding this comment.
Personally fine with it, apart from the memory footprint question.
auduchinok
commented
Sep 15, 2025
Ping. |
Types of certain expressions and patterns are captured during analysis, so features like code completion could use them later. This PR adds APIs to get these types and also captures types of some additional expressions.
In comparison with working with typed tree, this approach allows getting types of various expressions even when the resulting expression could not be created due to errors in the source.
I'm planning to add more reporting in the subsequent PRs. It would also be nice to revive #8828.