Skip to content

Checker: fix declaring type for abbreviated types extensions - #18909

Merged
T-Gro merged 4 commits into
dotnet:mainfrom
auduchinok:auduchinok/checker-recovery-abbrExtensionEntity
Sep 18, 2025
Merged

Checker: fix declaring type for abbreviated types extensions#18909
T-Gro merged 4 commits into
dotnet:mainfrom
auduchinok:auduchinok/checker-recovery-abbrExtensionEntity

Conversation

@auduchinok

@auduchinokauduchinok commented Sep 16, 2025

Copy link
Copy Markdown
Member

Continuation of #18645. Fixes DeclaringEntity for members defined in an abbreviated type extension:

moduleModuletyped= System.Collections.Generic.IDictionary<int, int>typed{caret}withmemberx.P=1

Since these members are now being analyzed due to the added recovery, it gets to a state that was never explicitly supported and tested, and there are places that are not ready for it.

The problem I've encountered in the Rider plugin tests is P member above assumes it's defined in the actual IDicitionary type, not in Module.

@auduchinok
auduchinok requested a review from a team as a code ownerSeptember 16, 2025 16:05
@github-actions

github-actionsBot commented Sep 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/10.0.100.md

@auduchinok
auduchinokforce-pushed the auduchinok/checker-recovery-abbrExtensionEntity branch from 18352c2 to 48dfdadCompareSeptember 17, 2025 10:51
edgarfgp
edgarfgp approved these changes Sep 17, 2025
View reviewed changes

@edgarfgpedgarfgp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingSep 18, 2025
@T-Gro
T-Gro merged commit 234ce6d into dotnet:mainSep 18, 2025
38 checks passed
@auduchinok
auduchinok deleted the auduchinok/checker-recovery-abbrExtensionEntity branch September 18, 2025 10:00
This was referenced Oct 14, 2025
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes
+1 more reviewer
@edgarfgpedgarfgpedgarfgp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auduchinok@edgarfgp@T-Gro